feat: add api to get ObjectType from ClassReflection and EnumCaseReflection #4099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the original logic, you have the class reflection instance, but you don't pass it into the ObjectType and instead opt to leave it null so that the class reflection is assigned the next time What is the reasoning for this? I would think that it would be better to pass along the class reflection instance since you already have it, but maybe I'm missing something... phpstan-src/src/Type/ObjectType.php Lines 136 to 147 in 5ab9acc |
calebdw
force-pushed
the
calebdw/push-poykyvwuvkyn
branch
from
366e72a to
e7d3e6b
Compare
|
Thank you, this is okay. Omitting of passing class reflection to ObjectType in the original code might change some behaviour for the better or worse as there will be slight differences in some scenario, we'll see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This PR adds the following two methods to the api:
ClassReflection::getObjectType(): ObjectTypeEnumCaseReflection:getEnumCaseObjectType(): EnumCaseObjectTypeMotivation
It's very easy to get all the
ClassReflections from aTypewith$type->getObjectClassReflections(). However, there have been several occasions where I've needed to go the other direction (get anObjectTypefrom aClassReflection) and have not been able to do so easily.I was digging around in the code, and I discovered a private static method
ObjectType::createFromReflection()that already did just this. So I opted to move the logic inObjectType::createFromReflection()toClassReflection::getObjectType()instead of simply making the private method public as I didn't think allowing child classes to statically call this method would be a good idea (e.g.,TemplateObjectType::createFromReflection())Thanks!